xujiangfeng001 commented on code in PR #3426:
URL:
https://github.com/apache/incubator-streampark/pull/3426#discussion_r1436257655
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/application/impl/ApplicationActionServiceImpl.java:
##########
@@ -390,6 +394,15 @@ public void start(Application appParam, boolean auto)
throws Exception {
ApiAlertException.throwIfTrue(
!application.isCanBeStart(), "[StreamPark] The application cannot be
started repeatedly.");
+ if (FlinkExecutionMode.isRemoteMode(application.getFlinkExecutionMode())
+ ||
FlinkExecutionMode.isYarnSessionMode(application.getFlinkExecutionMode())) {
+ checkBeforeStart(application);
+ }
+
+ if
(FlinkExecutionMode.isKubernetesSessionMode(application.getFlinkExecutionMode().getMode()))
{
+ checkBeforeStart(application);
+ }
Review Comment:
I think these two judgments can be combined into one, similar to:
```
if (FlinkExecutionMode.isRemoteMode(application.getFlinkExecutionMode())
||
FlinkExecutionMode.isSessionMode(application.getFlinkExecutionMode())) {
checkBeforeStart(application);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
