wolfboys commented on code in PR #3461:
URL:
https://github.com/apache/incubator-streampark/pull/3461#discussion_r1443969368
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/FlinkEnvService.java:
##########
@@ -29,11 +29,9 @@ public interface FlinkEnvService extends IService<FlinkEnv> {
* Checks if a specific version of Flink exists.
*
* @param version The version of Flink to check.
- * @return Returns an Integer value indicating the existence of the
specified version: - 0 if the
- * version exists - 1 if the version does not exist - null if the
version is invalid or an
- * error occurred during the check
+ * @return Returns an String value indicating the existence of the specified
version.
*/
- Integer check(FlinkEnv version);
+ String check(FlinkEnv version);
Review Comment:
I think it should be better to return type `FlinkEnvStatus`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
