wolfboys commented on code in PR #3461:
URL:
https://github.com/apache/incubator-streampark/pull/3461#discussion_r1443978936
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/FlinkEnvServiceImpl.java:
##########
@@ -49,8 +50,6 @@ public class FlinkEnvServiceImpl extends
ServiceImpl<FlinkEnvMapper, FlinkEnv>
* two places will be checked: <br>
* 1) name repeated <br>
* 2) flink-dist repeated <br>
- * -1) invalid path <br>
- * 0) ok <br>
*/
@Override
public Integer check(FlinkEnv version) {
Review Comment:
It should be better to return FlinkEnvStatus type instead of Integer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
