wolfboys commented on code in PR #3759: URL: https://github.com/apache/incubator-streampark/pull/3759#discussion_r1641753170
########## streampark-console/streampark-console-service/src/main/assembly/conf/config.yaml: ########## @@ -35,10 +35,11 @@ server: # system database, default h2, mysql|pgsql|h2 datasource: dialect: h2 #h2, mysql, pgsql + h2-data-dir: # if datasource.dialect is h2 ,you can configure the data dir Review Comment: > I don't think leaving the default value blank is a good option since we using `h2` as default database. Providing the default value allows users to use it directly without the need to configure it. If users use it in a production environment, we can suggest that users change to other values in the documentation. WDYT? We agree with your opinion that default values should be set, but "/tmp/xxx" is not a good solution. Perhaps `~/streampark/metadata` is a good idea, using `~` will automatically locate the user directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
