VampireAchao commented on code in PR #3759: URL: https://github.com/apache/incubator-streampark/pull/3759#discussion_r1641755204
########## streampark-console/streampark-console-service/src/main/assembly/conf/config.yaml: ########## @@ -35,10 +35,11 @@ server: # system database, default h2, mysql|pgsql|h2 datasource: dialect: h2 #h2, mysql, pgsql + h2-data-dir: # if datasource.dialect is h2 ,you can configure the data dir Review Comment: If it is for demonstration purposes, I prefer the /tmp directory. However, we need to consider users who might use it to run lightweight jobs and need persistence. In this case, the /tmp directory might not be suitable. I prefer the /data/streampark/ directory. This not only avoids the habitual cleaning of the /tmp directory that might lead to data loss but also aligns with the conventions of some projects, such as: Docker: By default, Docker containers use /data for storing persistent data. Elasticsearch: The default data directory for Elasticsearch is /var/lib/elasticsearch which often gets customized to /data/elasticsearch. MongoDB: Uses /data/db as the default directory for storing data. Prometheus: The default data directory is /var/lib/prometheus, and many setups prefer using /data/prometheus. These examples demonstrate a common practice of using the /data directory for persistent storage, ensuring stability and avoiding data loss due to temporary directory cleaning. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
