muyangye commented on issue #2181: URL: https://github.com/apache/streampipes/issues/2181#issuecomment-1839627740
> That's a good point. I'm not sure what the best option is here that won't break anything. Maybe we can change the names as long as we keep the internal file ID, but we should check this first. > > To do this, I would suggest creating a short list using this endpoint to see how we can deal with the problem of identical names. How do we solve this problem in the current implementation? > > (The `FileManager` is used in the REST endpoint in `PipelineElementFile`) Thanks for the reply! It sounds like we have a little bit different definition of **migration** here. Before this quoted reply, I thought by **migration** you mean in `FileMetadata` class, remove attributes `internalFilename` and `originalFilename`, then add a new attribute `filename` which represents the merged filename. However, after this reply, if I understand correctly, I think you might want to keep `internalFilename` and `originalFilename`. Then to avoid users to see/upload files of duplicate `originalFilename`, 1. Modify REST endpoints and ui to disallow the upload of files with duplicate `originalFilename`. 2. For files already having duplicate `originalFilename`, initiate a **migration** to change their `originalFilename` to something else. Either way, I think there are a lot of vague terms. Probably code explains better. I’ll submit a PR with my current understanding and we can always iterate on that :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
