[ 
https://issues.apache.org/struts/browse/STR-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40329
 ] 

Michael Jouravlev commented on STR-3009:
----------------------------------------

On a related note, should not ActionMapping have another findForward method 
that takes parameters? I think this would be a cleaner solution than creating 
ActionTransfer.

In regards to ActionRedirect, should not redirect/forward be defined in the 
config file after all? Was not it an original intent of Struts to externalize 
configuration? In case an action needs both forward and redirect to the same 
location, two <forward> entries can be defined, with different names. I don't 
see major difference coding-wise between an if statement selecting a forward, 
and building a dynamic ActionForward object. Conceptually, I think that former 
is preferable.

> ActionRedirect from ForwardConfig not redirecting properly?
> -----------------------------------------------------------
>
>                 Key: STR-3009
>                 URL: https://issues.apache.org/struts/browse/STR-3009
>             Project: Struts 1
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.3.5, 1.3.6
>            Reporter: Jason Millard
>
> While migrating from Struts 1.2.9 to Struts 1.3.5, I noticed ActionRedirect 
> was no longer redirecting as expected. 
> In the Struts 1.2.9, in 
>   public ActionRedirect(ForwardConfig baseConfig) 
> setRedirect was always being set to TRUE, like it is in every other 
> constructor.
> However, as of Struts 1.3.5 it is now being configured as
>  setRedirect(baseConfig.getRedirect());
> This seems to defeat the purpose of a ActionRedirect if you are trying to 
> generate one from a
>   mapping.findForward();

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to