[ 
https://issues.apache.org/jira/browse/WW-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865228#comment-15865228
 ] 

ASF subversion and git services commented on WW-4528:
-----------------------------------------------------

Commit 805cdd7754400149e166edc80b92fa2d67133d39 in struts's branch 
refs/heads/master from [~yasser.zamani]
[ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=805cdd7 ]

Add an Unit test to check if same issue as [WW-4528] has occurred

> ChainingInterceptor does not handle lists correctly for excludes and includes
> -----------------------------------------------------------------------------
>
>                 Key: WW-4528
>                 URL: https://issues.apache.org/jira/browse/WW-4528
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.3.24
>            Reporter: nikos dimitrakas
>             Fix For: 2.5.next
>
>
> The ChainingInterceptor has two parameters includes and excludes that 
> according to the documentation and the code are Collection<String>, but the 
> setters don't handle the specified values (that are loaded from the 
> struts.xml) as lists. So if i specify for example
> <interceptor-ref name="chain">
>        <param name="includes">x,y,z</param>
> </interceptor-ref>
> the includes variable of the interceptor becomes a Collection of one string 
> with the value "x,y,z" instead of a Collection of three strings "x", "y" and 
> "z".
> The behaviour should instead be similar to the ParametersInterceptor's 
> excludeParams or MethodFilterInterceptor's excludeMethods and includeMethods.
> It would also be good if the documentation included information and an 
> example with a list of parameters. The current documentation 
> (https://struts.apache.org/docs/chaining-interceptor.html) only says that the 
> parameters are lists, but the example only has one parameter



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to