[
https://issues.apache.org/jira/browse/WW-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865277#comment-15865277
]
Hudson commented on WW-4528:
----------------------------
SUCCESS: Integrated in Jenkins build Struts-JDK7-master #595 (See
[https://builds.apache.org/job/Struts-JDK7-master/595/])
[WW-4528] handling ChainingInterceptor excludes and includes lists as
(y.zamani.b: rev 0437efc6f91c2b78d84f673a63d45ef2765782db)
* (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java
* (edit)
core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java
* (edit)
core/src/test/java/com/opensymphony/xwork2/interceptor/ChainingInterceptorTest.java
[WW-4528] correcting testTwoExcludesPropertiesChained unit test (y.zamani.b:
rev 7140e0192b537f1ff388fbf00758b591a9cdeb6f)
* (edit)
core/src/test/java/com/opensymphony/xwork2/interceptor/ChainingInterceptorTest.java
[WW-4528] improving testTwoExcludesPropertiesChained unit test (y.zamani.b: rev
51c0bcbb8bf4103a5c97be0f6372725f792f470e)
* (edit)
core/src/test/java/com/opensymphony/xwork2/interceptor/ChainingInterceptorTest.java
Add an Unit test to check if same issue as [WW-4528] has occurred
(yasser.zamani: rev 805cdd7754400149e166edc80b92fa2d67133d39)
* (add)
core/src/test/java/com/opensymphony/xwork2/interceptor/ChainingInterceptorWithConfigTest.java
> ChainingInterceptor does not handle lists correctly for excludes and includes
> -----------------------------------------------------------------------------
>
> Key: WW-4528
> URL: https://issues.apache.org/jira/browse/WW-4528
> Project: Struts 2
> Issue Type: Bug
> Components: Core Interceptors
> Affects Versions: 2.3.24
> Reporter: nikos dimitrakas
> Fix For: 2.5.next
>
>
> The ChainingInterceptor has two parameters includes and excludes that
> according to the documentation and the code are Collection<String>, but the
> setters don't handle the specified values (that are loaded from the
> struts.xml) as lists. So if i specify for example
> <interceptor-ref name="chain">
> <param name="includes">x,y,z</param>
> </interceptor-ref>
> the includes variable of the interceptor becomes a Collection of one string
> with the value "x,y,z" instead of a Collection of three strings "x", "y" and
> "z".
> The behaviour should instead be similar to the ParametersInterceptor's
> excludeParams or MethodFilterInterceptor's excludeMethods and includeMethods.
> It would also be good if the documentation included information and an
> example with a list of parameters. The current documentation
> (https://struts.apache.org/docs/chaining-interceptor.html) only says that the
> parameters are lists, but the example only has one parameter
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
