[ 
https://issues.apache.org/jira/browse/WW-5000?focusedWorklogId=530367&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530367
 ]

ASF GitHub Bot logged work on WW-5000:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Jan/21 09:49
            Start Date: 03/Jan/21 09:49
    Worklog Time Spent: 10m 
      Work Description: coveralls commented on pull request #464:
URL: https://github.com/apache/struts/pull/464#issuecomment-753592218


   
   [![Coverage 
Status](https://coveralls.io/builds/36045024/badge)](https://coveralls.io/builds/36045024)
   
   Coverage decreased (-0.003%) to 49.821% when pulling 
**7ebf8fb8c94e5fa745f00098e6e89a31b261c8fc on WW-5000-constants** into 
**dcc53aebf983f6c0a48932262facb81f5d82815c on master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 530367)
    Time Spent: 20m  (was: 10m)

> Replace string literals with proper constants in @Inject
> --------------------------------------------------------
>
>                 Key: WW-5000
>                 URL: https://issues.apache.org/jira/browse/WW-5000
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Lukasz Lenart
>            Priority: Minor
>             Fix For: 2.6
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> In many places string literals are used instead of a proper reference to a 
> constant.
> {noformat}
> @Inject(value = "struts.xwork.chaining.copyMessages", required = false)
> @Inject(value = "struts.xwork.chaining.copyFieldErrors", required = false)
> @Inject(value = "struts.xwork.chaining.copyErrors", required = false)
> @Inject(value = "struts.javatemplates.defaultTemplateType", required = false)
> @Inject(value = "struts.javatemplates.customThemes", required = false)
> @Inject(value = "struts.objectFactory.cdi.jndiKey", required = false)
> @Inject(value = "enableAopSupport", required = false)
> @Inject(value = "struts.oval.validateJPAAnnotations")
> @Inject(value = "xwork.autoGrowCollectionLimit", required = false)
> @Inject(value = "logMissingProperties", required = false)
> @Inject(value="objectFactory.classloader", required=false)
> @Inject(value="allowStaticMethodAccess", required=false)
> @Inject(value="applicationContextPath",required=false)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to