[
https://issues.apache.org/jira/browse/WW-5000?focusedWorklogId=532611&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532611
]
ASF GitHub Bot logged work on WW-5000:
--------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jan/21 16:38
Start Date: 07/Jan/21 16:38
Worklog Time Spent: 10m
Work Description: JCgH4164838Gh792C124B5 commented on a change in pull
request #464:
URL: https://github.com/apache/struts/pull/464#discussion_r553443389
##########
File path:
core/src/test/java/com/opensymphony/xwork2/ognl/accessor/XWorkListPropertyAccessorTest.java
##########
@@ -85,7 +85,7 @@ public void testAutoGrowthCollectionLimit() {
public void testDeprecatedAutoGrowCollectionLimit() {
Review comment:
With the deprecated `setDeprecatedAutoGrowCollectionLimit()` being
dropped, I think `testDeprecatedAutoGrowCollectionLimit()` now becomes a
duplicate of `testAutoGrowthCollectionLimit()`.
If that is the case, then you might be able to drop
`setDeprecatedAutoGrowCollectionLimit()` completely, if you want.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 532611)
Time Spent: 1h 50m (was: 1h 40m)
> Replace string literals with proper constants in @Inject
> --------------------------------------------------------
>
> Key: WW-5000
> URL: https://issues.apache.org/jira/browse/WW-5000
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Reporter: Lukasz Lenart
> Priority: Minor
> Fix For: 2.6
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> In many places string literals are used instead of a proper reference to a
> constant.
> {noformat}
> @Inject(value = "struts.xwork.chaining.copyMessages", required = false)
> @Inject(value = "struts.xwork.chaining.copyFieldErrors", required = false)
> @Inject(value = "struts.xwork.chaining.copyErrors", required = false)
> @Inject(value = "struts.javatemplates.defaultTemplateType", required = false)
> @Inject(value = "struts.javatemplates.customThemes", required = false)
> @Inject(value = "struts.objectFactory.cdi.jndiKey", required = false)
> @Inject(value = "enableAopSupport", required = false)
> @Inject(value = "struts.oval.validateJPAAnnotations")
> @Inject(value = "xwork.autoGrowCollectionLimit", required = false)
> @Inject(value = "logMissingProperties", required = false)
> @Inject(value="objectFactory.classloader", required=false)
> @Inject(value="allowStaticMethodAccess", required=false)
> @Inject(value="applicationContextPath",required=false)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
