[
https://issues.apache.org/jira/browse/WW-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554573#comment-17554573
]
Burton Rhodes commented on WW-5191:
-----------------------------------
[~lukaszlenart] for consistency/clarity/readability you might move up some of
the "if/else" statements. This way all the "includes" are at the bottom.
Sorry, my OCD is kicking in.
*Reordered*
{code:java}
<#--
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
-->
<textarea<#rt/>
name="${(parameters.name!"")}"<#rt/>
<#if parameters.cols?has_content>
cols="${(parameters.cols!"")}"<#rt/>
</#if>
<#if parameters.rows?has_content>
rows="${(parameters.rows!"")}"<#rt/>
</#if>
<#if parameters.wrap?has_content>
wrap="${parameters.wrap}"<#rt/>
</#if>
<#if parameters.disabled!false>
disabled="disabled"<#rt/>
</#if>
<#if parameters.readonly!false>
readonly="readonly"<#rt/>
</#if>
<#if parameters.tabindex?has_content>
tabindex="${parameters.tabindex}"<#rt/>
</#if>
<#if parameters.id?has_content>
id="${parameters.id}"<#rt/>
</#if>
<#if parameters.maxlength?has_content>
maxlength="${parameters.maxlength}"<#rt/>
</#if>
<#if parameters.minlength?has_content>
minlength="${parameters.minlength}"<#rt/>
</#if>
<#if parameters.title?has_content>
title="${parameters.title}"<#rt/>
</#if>
<#if parameters.nameValue??>
<@s.property value="parameters.nameValue"/><#t/>
</#if>
<#include "/${parameters.templateDir}/${parameters.expandTheme}/css.ftl" />
<#include
"/${parameters.templateDir}/${parameters.expandTheme}/scripting-events.ftl" />
<#include
"/${parameters.templateDir}/${parameters.expandTheme}/common-attributes.ftl" />
<#include
"/${parameters.templateDir}/${parameters.expandTheme}/dynamic-attributes.ftl" />
><#rt/>
</textarea>{code}
> template/simple/textarea.ftl not rendering parameters correctly
> ---------------------------------------------------------------
>
> Key: WW-5191
> URL: https://issues.apache.org/jira/browse/WW-5191
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
> Affects Versions: 6.0.0
> Reporter: Burton Rhodes
> Assignee: Lukasz Lenart
> Priority: Major
> Fix For: 6.0.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The "simple" textarea.ftl (I haven't checked the other templates) does not
> have the ending ">" in the correct location. As a result, maxlength and
> minlength are displayed within the textarea editor.
>
> *Current*
> {code:java}
> <#include
> "/${parameters.templateDir}/${parameters.expandTheme}/scripting-events.ftl" />
> <#include
> "/${parameters.templateDir}/${parameters.expandTheme}/common-attributes.ftl"
> />
> <#include
> "/${parameters.templateDir}/${parameters.expandTheme}/dynamic-attributes.ftl"
> />
> ><#rt/> <#-- !! WRONG LOCATION !! -->
> <#if parameters.nameValue??>
> <@s.property value="parameters.nameValue"/><#t/>
> </#if>
> <#if parameters.maxlength?has_content>
> maxlength="${parameters.maxlength}"<#rt/>
> </#if>
> <#if parameters.minlength?has_content>
> minlength="${parameters.minlength}"<#rt/>
> </#if>
> </textarea> {code}
>
> *Should be*
> {code:java}
> <#include
> "/${parameters.templateDir}/${parameters.expandTheme}/scripting-events.ftl" />
> <#include
> "/${parameters.templateDir}/${parameters.expandTheme}/common-attributes.ftl"
> />
> <#include
> "/${parameters.templateDir}/${parameters.expandTheme}/dynamic-attributes.ftl"
> />
> <#if parameters.nameValue??>
> <@s.property value="parameters.nameValue"/><#t/>
> </#if>
> <#if parameters.maxlength?has_content>
> maxlength="${parameters.maxlength}"<#rt/>
> </#if>
> <#if parameters.minlength?has_content>
> minlength="${parameters.minlength}"<#rt/>
> </#if>
> ><#rt/> <#-- !! CORRECT LOCATION !! -->
> </textarea>{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
