[
https://issues.apache.org/jira/browse/WW-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554592#comment-17554592
]
ASF subversion and git services commented on WW-5191:
-----------------------------------------------------
Commit 0e4d5962e1d774d6791b2f713263d9e9fcd41aab in struts's branch
refs/heads/WW-5191-textarea-max-length from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=0e4d5962e ]
WW-5191 Fixes placement of maxLength and minLength attributes in <s:textarea/>
tag
> template/simple/textarea.ftl not rendering parameters correctly
> ---------------------------------------------------------------
>
> Key: WW-5191
> URL: https://issues.apache.org/jira/browse/WW-5191
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
> Affects Versions: 6.0.0
> Reporter: Burton Rhodes
> Assignee: Lukasz Lenart
> Priority: Major
> Fix For: 6.0.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The "simple" textarea.ftl (I haven't checked the other templates) does not
> have the ending ">" in the correct location. As a result, maxlength and
> minlength are displayed within the textarea editor.
>
> *Current*
> {code:java}
> <#include
> "/${parameters.templateDir}/${parameters.expandTheme}/scripting-events.ftl" />
> <#include
> "/${parameters.templateDir}/${parameters.expandTheme}/common-attributes.ftl"
> />
> <#include
> "/${parameters.templateDir}/${parameters.expandTheme}/dynamic-attributes.ftl"
> />
> ><#rt/> <#-- !! WRONG LOCATION !! -->
> <#if parameters.nameValue??>
> <@s.property value="parameters.nameValue"/><#t/>
> </#if>
> <#if parameters.maxlength?has_content>
> maxlength="${parameters.maxlength}"<#rt/>
> </#if>
> <#if parameters.minlength?has_content>
> minlength="${parameters.minlength}"<#rt/>
> </#if>
> </textarea> {code}
>
> *Should be*
> {code:java}
> <#include
> "/${parameters.templateDir}/${parameters.expandTheme}/scripting-events.ftl" />
> <#include
> "/${parameters.templateDir}/${parameters.expandTheme}/common-attributes.ftl"
> />
> <#include
> "/${parameters.templateDir}/${parameters.expandTheme}/dynamic-attributes.ftl"
> />
> <#if parameters.nameValue??>
> <@s.property value="parameters.nameValue"/><#t/>
> </#if>
> <#if parameters.maxlength?has_content>
> maxlength="${parameters.maxlength}"<#rt/>
> </#if>
> <#if parameters.minlength?has_content>
> minlength="${parameters.minlength}"<#rt/>
> </#if>
> ><#rt/> <#-- !! CORRECT LOCATION !! -->
> </textarea>{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
