yasserzamani commented on PR #573:
URL: https://github.com/apache/struts/pull/573#issuecomment-1200126630

   Hi @JCgH4164838Gh792C124B5 sorry I was wrong yesterday. Your sample app 
works, however you need to apply a few fixes on your previous work which I 
introduced by #581 - I learnt them from already working extension points like 
ObjectFactory and ActionFactory.
   
   Please feel free to either merge my PR and rebase your PR based on it, or 
simply redo same fixes on your PR and close my PR please.
   
   Thanks again for your works! and sorry for my late answer.
   
   BTW regarding DTD problem, please apply following patch on your sample app
   ```diff
   Index: src/main/resources/struts.xml
   IDEA additional info:
   Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
   <+>UTF-8
   ===================================================================
   --- src/main/resources/struts.xml    (date 1659109456598)
   +++ src/main/resources/struts.xml    (date 1659109456598)
   @@ -1,7 +1,7 @@
    <?xml version="1.0" encoding="UTF-8" ?>
    <!DOCTYPE struts PUBLIC
   -        "-//Apache Software Foundation//DTD Struts Configuration 2.6//EN"
   -        "http://struts.apache.org/dtds/struts-2.6.dtd";>
   +        "-//Apache Software Foundation//DTD Struts Configuration 6.0//EN"
   +        "http://struts.apache.org/dtds/struts-6.0.dtd";>
    
    <struts>
    
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@struts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to