yasserzamani commented on PR #573: URL: https://github.com/apache/struts/pull/573#issuecomment-1201250072
Thank you @JCgH4164838Gh792C124B5 for testing bits! > The subtleties for how the naming/associations for the DI configuration change the behaviour are still a bit mysterious to me For me too. Today I also tried a lot to make it working as you planned in previous version. Finally instead of I fixing Struts, it fixed me :)) and taught me that looks like that when you want to introduce an extension point, then you shouldn't use a concrete name in `.factory(` and let Struts use its default name. Otherwise we cannot inject it by a dynamic name. At least I couldn't. Instead, we should define aliases like what's done in `.alias(`. At bottom this LGTM and will merge. Just one thing. A few tests which are from past and not related, are deleted, I think by mistake, right? If so, then could you revert them. thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@struts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
