sepe81 commented on code in PR #657:
URL: https://github.com/apache/struts/pull/657#discussion_r1091847537
##########
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java:
##########
@@ -164,13 +174,10 @@ public boolean equals(Object o) {
if (this == o) {
return true;
}
-
if (!(o instanceof XmlConfigurationProvider)) {
return false;
}
-
- final XmlConfigurationProvider xmlConfigurationProvider =
(XmlConfigurationProvider) o;
-
+ XmlConfigurationProvider xmlConfigurationProvider =
(XmlConfigurationProvider) o;
Review Comment:
https://stackoverflow.com/questions/154314/when-should-one-use-final-for-method-parameters-and-local-variables/154510#154510
LGTM, but for this existing line "If I'm in someone else's code, I'm not going
to pull them out but if I'm writing new code I won't put them in." would fit.
With your explanation, both styles would be ok for me. Maybe @lukaszlenart
has some recommendation according to the Struts coding style?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@struts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
