jdyer1 commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1799585096
I added several new commits to my fork. Now all code compiles and all unit tests pass, with these 5 new caveats. 1. I ignored freemarker tests (REVERT these commits) - 8d465c66a871cb5f7df4781c556f7d71e2932af1 - 1c43fd1dc77f0478823c668bca8a0a31f7e9dd6b - 908d06483906c50d448795cf99547da9f91a9ef8 2. I ignored Commons-Upload tests (REVERT these commits) - e4fa6e40ef99190a82e071900e937886e7f1a381 - f0df35f2e4d3fd1939f58a425729640a4d612ce9 3. I ignored "embedded jsp plugin" test. Possibly remove this deprecated plugin? Or, fix and REVERT this commit. - 7f12f15d92177b5776255aee2e315e5cc55e9ffc 4. I Removed deprcated OVAL plugin. Dependency "net.sf.oval" depends on javax.persistence, no "jakarta" compatible release available. 5. The "Struts 2 Showcase Webapp" integration test does not work. I do not know how to fix it, but it seems the web server is not starting. Probably "Struts 2 Rest Showcase Webapp" has the same issue. ----- I think these are the next TODO's: 1. Fix common-uploads to work with newer version 2. Figure out what to do about freemarker/sitemesh (perhaps use eclipse transformer? https://github.com/eclipse/transformer) 3. Fix tests for "embedded jsp plugin" or remove this deprecated plugin 4. Fix the "Struts 2 Showcase Webapp" integration tests If anyone can give input as to if you feel this is the right track, I would appreciate it. I will continue to work on some of these things as my time allows. It would be wonderful to also see some activity from seasoned Struts developers! I think having a Jakarta EE 9+ version of Struts to be important as we all need to eventually migrate our applications to stay on supported runtimes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@struts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
