tyme-dev commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1807217384
@jdyer1 I've went ahead and got Commons-Upload tests working and converted over to Fileupload2-jakarta. since your pr is the reference one, I've went ahead and did a pull request on your branch in order to get it over here. Only a few things were trip-ups : - fileupload doesn't seem to be reporting actual size of files if they are larger than size limit, so i had to change error messages. - setting threshold for writing file to disk, using -1 no longer seems to work, neither does 0. Got it working with a threshold of 1 though. - had to reorder exception instance check since FileSize exceptions have changed which exception classes they inherit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@struts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
