[ 
https://issues.apache.org/jira/browse/WW-5251?focusedWorklogId=911817&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911817
 ]

ASF GitHub Bot logged work on WW-5251:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Mar/24 13:10
            Start Date: 27/Mar/24 13:10
    Worklog Time Spent: 10m 
      Work Description: brianandle commented on code in PR #898:
URL: https://github.com/apache/struts/pull/898#discussion_r1541079931


##########
core/src/main/java/org/apache/struts2/interceptor/ParameterAware.java:
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.struts2.interceptor;
+
+import org.apache.struts2.dispatcher.HttpParameters;
+
+import java.util.Map;
+
+@Deprecated
+public interface ParameterAware extends 
org.apache.struts2.action.ParametersAware {
+
+    void setParameters(Map map);
+
+    @Override
+    default void withParameters(HttpParameters parameters) {
+        setParameters(parameters);

Review Comment:
   From Struts 6.0.0 announcement page.
   
   Version change
   
   You can be surprised by the version change, previously we have been using 
Struts 2.5.x versioning schema, but this was a bit misleading. Struts 2 is a 
different framework than Struts 1 and its versioning is supposed to start with 
1.0.0, yet that never happened. With each breaking changes release (like Struts 
2.5), we had been only upgrading the MINOR part of the versioning schema. To 
fix that problem as from Struts 2 ver. 6.0.0 (aka Struts 2.6) we adopt a proper 
SemVer to avoid such confusion.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 911817)
    Time Spent: 2h  (was: 1h 50m)

> Remove deprecated interfaces used with ServletConfigInterceptor
> ---------------------------------------------------------------
>
>                 Key: WW-5251
>                 URL: https://issues.apache.org/jira/browse/WW-5251
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Interceptors
>            Reporter: Lukasz Lenart
>            Assignee: Lukasz Lenart
>            Priority: Major
>             Fix For: 7.0.0
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> {{ServletConfigInterceptor}} supports a bunch of deprecated interfaces which 
> already have proper replacement and they should be removed
> * {{org.apache.struts2.util.ServletContextAware}}
> * {{org.apache.struts2.interceptor.ServletRequestAware}}
> * {{org.apache.struts2.interceptor.ServletResponseAware}}
> * {{org.apache.struts2.interceptor.ParameterAware}}
> * {{org.apache.struts2.interceptor.SessionAware}}
> * {{org.apache.struts2.interceptor.ApplicationAware}}
> * {{org.apache.struts2.interceptor.PrincipalAware}}
> all these interfaces have proper replacement in {{org.apache.struts2.action}} 
> package



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to