[
https://issues.apache.org/jira/browse/WW-5251?focusedWorklogId=911824&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911824
]
ASF GitHub Bot logged work on WW-5251:
--------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/24 13:25
Start Date: 27/Mar/24 13:25
Worklog Time Spent: 10m
Work Description: kusalk commented on code in PR #898:
URL: https://github.com/apache/struts/pull/898#discussion_r1541103007
##########
core/src/main/java/org/apache/struts2/interceptor/ParameterAware.java:
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.struts2.interceptor;
+
+import org.apache.struts2.dispatcher.HttpParameters;
+
+import java.util.Map;
+
+@Deprecated
+public interface ParameterAware extends
org.apache.struts2.action.ParametersAware {
+
+ void setParameters(Map map);
+
+ @Override
+ default void withParameters(HttpParameters parameters) {
+ setParameters(parameters);
Review Comment:
SemVer also definitely doesn't have a 4th version component but here we are
with version 6.3.0.2 🤷🏾
I think we've probably deleted too much code to be able to reinstate full
API compatibility with version 6.0.0 at this point in time. Technically all
`protected`+ methods defined in Struts extension point classes are also public
API but these have also been aggressively refactored. But we can try reinstate
some of the most used APIs as per your Jira card, at least the ones we can
verify to not compromise security.
Also, adding a new dependency (Caffeine) isn't a SemVer violation as far as
I know.
Issue Time Tracking
-------------------
Worklog Id: (was: 911824)
Time Spent: 2.5h (was: 2h 20m)
> Remove deprecated interfaces used with ServletConfigInterceptor
> ---------------------------------------------------------------
>
> Key: WW-5251
> URL: https://issues.apache.org/jira/browse/WW-5251
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Interceptors
> Reporter: Lukasz Lenart
> Assignee: Lukasz Lenart
> Priority: Major
> Fix For: 7.0.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> {{ServletConfigInterceptor}} supports a bunch of deprecated interfaces which
> already have proper replacement and they should be removed
> * {{org.apache.struts2.util.ServletContextAware}}
> * {{org.apache.struts2.interceptor.ServletRequestAware}}
> * {{org.apache.struts2.interceptor.ServletResponseAware}}
> * {{org.apache.struts2.interceptor.ParameterAware}}
> * {{org.apache.struts2.interceptor.SessionAware}}
> * {{org.apache.struts2.interceptor.ApplicationAware}}
> * {{org.apache.struts2.interceptor.PrincipalAware}}
> all these interfaces have proper replacement in {{org.apache.struts2.action}}
> package
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
