[ 
https://issues.apache.org/jira/browse/WW-5468?focusedWorklogId=937735&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-937735
 ]

ASF GitHub Bot logged work on WW-5468:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Oct/24 12:08
            Start Date: 12/Oct/24 12:08
    Worklog Time Spent: 10m 
      Work Description: kusalk commented on code in PR #1072:
URL: https://github.com/apache/struts/pull/1072#discussion_r1797691384


##########
core/src/test/java/com/opensymphony/xwork2/ModelDrivenAction.java:
##########
@@ -44,7 +44,6 @@ public String getFoo() {
     /**
      * @return the model to be pushed onto the ValueStack after the Action 
itself
      */
-    @StrutsParameter(depth = 2)

Review Comment:
   I removed all these annotations on `ModelDriven` Action model getters as 
they are no longer required (not that they were being detected correctly 
previously)





Issue Time Tracking
-------------------

    Worklog Id:     (was: 937735)
    Time Spent: 2h  (was: 1h 50m)

> ModelDriven is not compatible with @StrutsParameter
> ---------------------------------------------------
>
>                 Key: WW-5468
>                 URL: https://issues.apache.org/jira/browse/WW-5468
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 7.0.0
>            Reporter: Lukasz Lenart
>            Priority: Major
>             Fix For: 7.0.0
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Currently if a Struts webapp uses {{ModelDriven<T>}} it won't be possible to 
> use {{@StrutsParameter}} annotation on {{#getModel()}} getter.
> Use rest-angular as example
> https://github.com/apache/struts-examples/blob/master/rest-angular/src/main/resources/struts.xml#L13



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to