[
https://issues.apache.org/jira/browse/WW-5468?focusedWorklogId=937762&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-937762
]
ASF GitHub Bot logged work on WW-5468:
--------------------------------------
Author: ASF GitHub Bot
Created on: 13/Oct/24 05:16
Start Date: 13/Oct/24 05:16
Worklog Time Spent: 10m
Work Description: lukaszlenart commented on code in PR #1072:
URL: https://github.com/apache/struts/pull/1072#discussion_r1798047410
##########
core/src/test/java/org/apache/struts2/interceptor/parameter/StrutsParameterAnnotationTest.java:
##########
@@ -343,6 +360,14 @@ public Map<String, Pojo> getPublicPojoMapDepthTwo() {
}
}
- class Pojo {
+ static class ModelAction implements ModelDriven<Pojo> {
Review Comment:
There is one more case where `ModelDriven<Object>` is used and then
`getModel()` can return conditional model, either a `List<Pojo>` or `Pojo`
itself. See [that
example](https://github.com/apache/struts-examples/blob/master/rest-angular/src/main/java/org/apache/examples/struts/actions/data/OrderController.java#L71-L80)
Issue Time Tracking
-------------------
Worklog Id: (was: 937762)
Time Spent: 2h 40m (was: 2.5h)
> ModelDriven is not compatible with @StrutsParameter
> ---------------------------------------------------
>
> Key: WW-5468
> URL: https://issues.apache.org/jira/browse/WW-5468
> Project: Struts 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 7.0.0
> Reporter: Lukasz Lenart
> Priority: Major
> Fix For: 7.0.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Currently if a Struts webapp uses {{ModelDriven<T>}} it won't be possible to
> use {{@StrutsParameter}} annotation on {{#getModel()}} getter.
> Use rest-angular as example
> https://github.com/apache/struts-examples/blob/master/rest-angular/src/main/resources/struts.xml#L13
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
