[ 
https://issues.apache.org/jira/browse/WW-5444?focusedWorklogId=993015&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-993015
 ]

ASF GitHub Bot logged work on WW-5444:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Nov/25 17:52
            Start Date: 23/Nov/25 17:52
    Worklog Time Spent: 10m 
      Work Description: lukaszlenart opened a new pull request, #1422:
URL: https://github.com/apache/struts/pull/1422

   ## Summary
   
   This PR adds the HTML5 theme to Struts core framework and implements 
comprehensive unit testing:
   
   - Migrated HTML5 theme from showcase to 
`core/src/main/resources/template/html5/`
   - Fixed all 32 HTML5 templates to use `attributes` instead of deprecated 
`parameters` variable
   - Added `theme.properties` with parent theme configuration
   - Implemented unit tests for 13 UI components (26 test methods total)
   - All tests passing (100% success rate)
   
   ## Changes
   
   ### Theme Implementation
   - Created 45 HTML5 FreeMarker templates in core
   - Added `theme.properties` with `parent=simple` configuration
   - Migrated templates from `parameters` to `attributes` variable
   
   ### Unit Tests
   Added `testGenericHtml5()` and `testGenericHtml5_clearTagStateSet()` methods 
to:
   - TextfieldTest, TextareaTest, PasswordTest
   - CheckboxTest, CheckboxListTest, RadioTest
   - SelectTest, FileTest, HiddenTest
   - LabelTest, ComboBoxTest, ResetTest, SubmitTest
   
   Excluded: DoubleSelect and UpDownSelect (not supported in HTML5 theme)
   
   ### Documentation
   - Added implementation plan and testing research documents
   - Updated CLAUDE.md with current guidelines
   
   ## Test Results
   - 26/26 HTML5 theme tests passing
   - All template path resolution working correctly
   - Proper theme inheritance from simple theme
   
   Closes [WW-5444](https://issues.apache.org/jira/browse/WW-5444)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)




Issue Time Tracking
-------------------

            Worklog Id:     (was: 993015)
    Remaining Estimate: 0h
            Time Spent: 10m

> Implement a new html5 theme
> ---------------------------
>
>                 Key: WW-5444
>                 URL: https://issues.apache.org/jira/browse/WW-5444
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: Core Tags
>            Reporter: Lukasz Lenart
>            Assignee: Lukasz Lenart
>            Priority: Major
>             Fix For: 7.2.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Instead of trying to fix existing tags, it's easier to introduce a new theme 
> which will provide HTML 5 compatible tags



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to