[
https://issues.apache.org/jira/browse/WW-5444?focusedWorklogId=993032&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-993032
]
ASF GitHub Bot logged work on WW-5444:
--------------------------------------
Author: ASF GitHub Bot
Created on: 24/Nov/25 07:21
Start Date: 24/Nov/25 07:21
Worklog Time Spent: 10m
Work Description: sepe81 commented on code in PR #1422:
URL: https://github.com/apache/struts/pull/1422#discussion_r2554890696
##########
thoughts/shared/plans/2025-11-23-WW-5444-move-html5-theme-to-core.md:
##########
Review Comment:
That looks interesting, and in other projects I also considered
incorporating part of the "plan". Are you planning to include the "thoughts"
folder in main?
##########
.claude/agents/test-runner.md:
##########
@@ -1,6 +1,6 @@
---
name: test-runner
-description: Use this agent to intelligently execute and analyze Apache Struts
tests using Maven, with specialized knowledge of Struts testing patterns,
coverage analysis, and security testing. Examples: <example>Context: Developer
wants to run tests after implementing a new feature. user: 'Can you run the
tests for my changes?' assistant: 'I'll use the test-runner agent to execute
the relevant tests and analyze the results.' <commentary>The user needs test
execution and analysis, which is the test-runner agent's
specialty.</commentary></example> <example>Context: CI/CD pipeline needs
comprehensive testing. user: 'Run all tests and check coverage for the security
interceptor changes' assistant: 'Let me use the test-runner agent to run
comprehensive tests and analyze coverage for your security changes.'
<commentary>This requires intelligent test execution and coverage analysis,
perfect for the test-runner agent.</commentary></example>
+description: Use this agent to intelligently execute and analyze Apache Struts
tests using Maven, with specialized knowledge of Struts testing patterns,
coverage analysis, and security testing. Examples: <example>Context: Developer
wants to run tests after implementing a new feature. user: 'Can you run the
tests for my changes?' assistant: 'I willll use the test-runner agent to
execute the relevant tests and analyze the results.' <commentary>The user needs
test execution and analysis, which is the test-runner agent's
specialty.</commentary></example> <example>Context: CI/CD pipeline needs
comprehensive testing. user: 'Run all tests and check coverage for the security
interceptor changes' assistant: 'Let me use the test-runner agent to run
comprehensive tests and analyze coverage for your security changes.'
<commentary>This requires intelligent test execution and coverage analysis,
perfect for the test-runner agent.</commentary></example>
Review Comment:
```suggestion
description: Use this agent to intelligently execute and analyze Apache
Struts tests using Maven, with specialized knowledge of Struts testing
patterns, coverage analysis, and security testing. Examples: <example>Context:
Developer wants to run tests after implementing a new feature. user: 'Can you
run the tests for my changes?' assistant: 'I will use the test-runner agent to
execute the relevant tests and analyze the results.' <commentary>The user needs
test execution and analysis, which is the test-runner agent's
specialty.</commentary></example> <example>Context: CI/CD pipeline needs
comprehensive testing. user: 'Run all tests and check coverage for the security
interceptor changes' assistant: 'Let me use the test-runner agent to run
comprehensive tests and analyze coverage for your security changes.'
<commentary>This requires intelligent test execution and coverage analysis,
perfect for the test-runner agent.</commentary></example>
```
or just revert this line?
Issue Time Tracking
-------------------
Worklog Id: (was: 993032)
Time Spent: 20m (was: 10m)
> Implement a new html5 theme
> ---------------------------
>
> Key: WW-5444
> URL: https://issues.apache.org/jira/browse/WW-5444
> Project: Struts 2
> Issue Type: New Feature
> Components: Core Tags
> Reporter: Lukasz Lenart
> Assignee: Lukasz Lenart
> Priority: Major
> Fix For: 7.2.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Instead of trying to fix existing tags, it's easier to introduce a new theme
> which will provide HTML 5 compatible tags
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
