[
https://issues.apache.org/jira/browse/WW-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18127812#comment-18127812
]
Lukasz Lenart edited comment on WW-3655 at 10/16/26 12:09 PM:
--------------------------------------------------------------
This was resolved by WW-4169, first released in Struts 2.3.17.
{{FreemarkerResult}} now resolves a relative location against the action
namespace instead of the request URI, so the request path no longer affects
which template is loaded.
I checked this with a regression test: a request to
{{/com/acme/actions/Action.class/}} with an empty result location. When I
temporarily put back the old request-URI resolution, the test fails (the
template at that path is loaded and written to the response). On current
{{main}} it passes.
Closing as fixed.
was (Author: lukaszlenart):
This was resolved by [WW-4169|https://issues.apache.org/jira/browse/WW-4169],
first released in Struts 2.3.17. {{FreemarkerResult}} now resolves a relative
location against the action namespace instead of the request URI, so the
request path no longer affects which template is loaded.
I checked this with a regression test: a request to
{{/com/acme/actions/Action.class/}} with an empty result location. When I
temporarily put back the old request-URI resolution, the test fails (the
template at that path is loaded and written to the response). On current
{{main}} it passes.
Closing as fixed.
> Freemarker result loads request uri as template
> -----------------------------------------------
>
> Key: WW-3655
> URL: https://issues.apache.org/jira/browse/WW-3655
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.2.3
> Reporter: Johno Crawford
> Assignee: Maurizio Cucchiara
> Priority: Major
> Fix For: 7.5.0
>
>
> If the template location is either null or an empty string ""
> FreemarkerResult will take the request uri
> org.apache.struts2.views.freemarker.FreemarkerResult#doExecute and load it as
> a template.
> Example url, http://localhost:8080/com/acme/actions/Action.class/ would load
> /com/acme/actions/Action.class/ as a template and dump the bytecode in the
> response.
> The "feature" / culprit below seems a little exotic, however someone may be
> relying on it.. (same actions handling stuff in different directories?)
> {code}
> if (!locationArg.startsWith("/")) {
> String base = ResourceUtil.getResourceBase(req);
> locationArg = base + "/" + locationArg;
> }
> {code}
> To mitigate the problem and maintain previous functionality we could throw an
> exception if the template location is empty, I have created a pull request
> with my proposed fix https://github.com/apache/struts2/pull/1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
