[jira] [Work logged] (WW-3655) Freemarker result loads request uri as template

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/WW-3655?focusedWorklogId=1047827&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1047827
 ]

ASF GitHub Bot logged work on WW-3655:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Oct/26 12:13
            Start Date: 16/Oct/26 12:13
    Worklog Time Spent: 10m 
      Work Description: sonarqubecloud[bot] commented on PR #2037:
URL: https://github.com/apache/struts/pull/2037#issuecomment-6215266982

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=2037) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=2037&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=2037&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=2037&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=2037&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=2037&metric=new_duplicated_lines_density&view=list)
  
     
   <!

Issue Time Tracking
-------------------

    Worklog Id:     (was: 1047827)
    Time Spent: 20m  (was: 10m)

> Freemarker result loads request uri as template
> -----------------------------------------------
>
>                 Key: WW-3655
>                 URL: https://issues.apache.org/jira/browse/WW-3655
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.2.3
>            Reporter: Johno Crawford
>            Assignee: Maurizio Cucchiara
>            Priority: Major
>             Fix For: 7.5.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> If the template location is either null or an empty string "" 
> FreemarkerResult will take the request uri 
> org.apache.struts2.views.freemarker.FreemarkerResult#doExecute and load it as 
> a template.
> Example url, http://localhost:8080/com/acme/actions/Action.class/ would load 
> /com/acme/actions/Action.class/ as a template and dump the bytecode in the 
> response.
> The "feature" / culprit below seems a little exotic, however someone may be 
> relying on it.. (same actions handling stuff in different directories?)
> {code}
> if (!locationArg.startsWith("/")) {
>             String base = ResourceUtil.getResourceBase(req);
>             locationArg = base + "/" + locationArg;
> }
> {code}
> To mitigate the problem and maintain previous functionality we could throw an 
> exception if the template location is empty, I have created a pull request 
> with my proposed fix https://github.com/apache/struts2/pull/1



--
This message was sent by Atlassian Jira
(v8.20.10#820010)