[
https://issues.apache.org/jira/browse/SVN-4781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664827#comment-16664827
]
Julian Foad edited comment on SVN-4781 at 10/26/18 8:01 AM:
------------------------------------------------------------
[r1700966|http://svn.apache.org/r1700966] added the following code to
1.10.x/subversion/bindings/swig/include/svn_types.swg:
{code}
%typemap(in,warning="901:FIXME: Missing old_value_p typemap") const
svn_string_t *const *old_value_p {
{{#if defined(SWIGRUBY) && SWIG_VERSION <= 0x010329 }}
/* Ruby fails to define $symname. */
SWIG_exception(SWIG_ValueError, "Function is not implemented yet");
#else
SWIG_exception(SWIG_ValueError, "$symname is not implemented yet");
#endif
}{code}
which changed the generated bindings like this:
{code:c}
--- 1.9.x/obj-dir/subversion/bindings/swig/python/svn_ra.c
+++ 1.10.x/obj-dir/subversion/bindings/swig/python/svn_ra.c
@@ -7182,10 +7184,8 @@ SWIGINTERN PyObject *_wrap_svn_ra_change
}
}
{
- arg4 = (svn_string_t **)svn_swig_py_must_get_ptr(obj3,
SWIGTYPE_p_p_svn_string_t, svn_argnum_obj3);
- if (PyErr_Occurred()) {
- SWIG_fail;
- }
+ SWIG_exception(SWIG_ValueError, "svn_ra_change_rev_prop2 is not
implemented yet");
+
}
{
if (obj4 == Py_None){code}
was (Author: julianfoad):
[r1700966|http://svn.apache.org/r1700966] added the following code to
1.10.x/subversion/bindings/swig/include/svn_types.swg:
{{%typemap(in,warning="901:FIXME: Missing old_value_p typemap") const
svn_string_t *const *old_value_p {}}
\{{#if defined(SWIGRUBY) && SWIG_VERSION <= 0x010329 }}
{{ /* Ruby fails to define $symname. */}}
{{ SWIG_exception(SWIG_ValueError, "Function is not implemented yet");}}
{{#else}}
{{ SWIG_exception(SWIG_ValueError, "$symname is not implemented yet");}}
{{#endif}}
{{}}}
which changed the generated bindings like this:
{{--- 1.9.x/obj-dir/subversion/bindings/swig/python/svn_ra.c}}
{{+++ 1.10.x/obj-dir/subversion/bindings/swig/python/svn_ra.c}}
{{@@ -7182,10 +7184,8 @@ SWIGINTERN PyObject *_wrap_svn_ra_change}}
{{ }}}
{{ }}}
{{ {}}
{{- arg4 = (svn_string_t **)svn_swig_py_must_get_ptr(obj3,
SWIGTYPE_p_p_svn_string_t, svn_argnum_obj3);}}
{{- if (PyErr_Occurred()) {}}
{{- SWIG_fail;}}
{{- }}}
{{+ SWIG_exception(SWIG_ValueError, "svn_ra_change_rev_prop2 is not
implemented yet");}}
{{+ }}
{{ }}}
{{ {}}
{{ if (obj4 == Py_None)}}
> swig-py change_rev_prop2() crashes
> ----------------------------------
>
> Key: SVN-4781
> URL: https://issues.apache.org/jira/browse/SVN-4781
> Project: Subversion
> Issue Type: Task
> Components: bindings_swig
> Affects Versions: 1.9.x, 1.10.x
> Reporter: Julian Foad
> Priority: Major
>
> [http://svn.apache.org/r1700966] – "Disable wrappers that aren't working" –
> turns the crash into a descriptive exception, from 1.10.x onward.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
