http://openoffice.org/bugzilla/show_bug.cgi?id=117814
--- Comment #11 from [email protected] 2011-04-12 12:59:46 --- The SwNewDBMgr class is huge and ties the code in core that interfaces with it to the classes SwDocShell and SwWrtShell. These classes are needed only for mail merge. So by moving out the mail merge functionality into a second class we can get rid of all ui dependencies in core introduced by that. Mail merge itself is not part of the core. The split get a little bit complicated because unfortunately both the core code and the mail merge code expect to have access to the DBMgr through SwDoc. So I again distributed the code over SwDoc (GetNewDBMgr) and SwDocShell (GetMergeMgr). This also means that we can't just derive the MergeMgr from the NewDBMgr, they have to be separate instances where the latter is used by the former. Another complication is that in the mail merge process the DBMgr is exchanged (at least temporarily). So we must guarantee that when we exchange the MergeMgr at the SwDocShell the DBMgr at the SwDoc must be exchanged also, both objects are tied together (but only the MergeMgr knows about that). changeset 26496d5625a3 http://hg.services.openoffice.org/cws/swcoreseparation/rev/26496d5625a3 -- Configure bugmail: http://openoffice.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Bugzilla. Please log into the website and enter your comments. --------------------------------------------------------------------- -- ----------------------------------------------------------------- To unsubscribe send email to [email protected] For additional commands send email to [email protected] with Subject: help -- ----------------------------------------------------------------- To unsubscribe send email to [email protected] For additional commands send email to [email protected] with Subject: help
