http://openoffice.org/bugzilla/show_bug.cgi?id=117814
--- Comment #15 from [email protected] 2011-04-12 13:57:22 --- In the mentioned mdiexp.hxx there are some global functions that receive a ViewShell as parameter. They are implemented in source/ui/docvw/edtwin3.cxx. The implementation requires access to an SwView or SwPagePreview through the ViewShell. This is done by making the SfxViewShell known to the ViewShell, retrieving it from there and type casting it to the desired class. This is what virtual methods are for, aren't they? So I converted all these functions into virtual methods in class ViewShell. A real implementation is available only in SwWrtShell, the implementations in the class ViewShell are empty or default implementations. This reflects the former situation that the functions required the presence of an SwView. The code working on SwPagePreview as replaced by a new class deriving from ViewShell that is used as a ViewShell instance in SwPagePreview. As a side effect, the Get/SetSfxViewShell methods in class ViewShell became obsolete. A good indication. :-) changeset c744b799d09f http://hg.services.openoffice.org/cws/swcoreseparation/rev/c744b799d09f -- Configure bugmail: http://openoffice.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Bugzilla. Please log into the website and enter your comments. --------------------------------------------------------------------- -- ----------------------------------------------------------------- To unsubscribe send email to [email protected] For additional commands send email to [email protected] with Subject: help -- ----------------------------------------------------------------- To unsubscribe send email to [email protected] For additional commands send email to [email protected] with Subject: help
