[
https://issues.apache.org/jira/browse/SYSTEMML-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15539350#comment-15539350
]
Mike Dusenberry edited comment on SYSTEMML-995 at 10/1/16 11:47 PM:
--------------------------------------------------------------------
Indeed, the blocksizes were set to the default "1" when the metadata is
missing/empty. Like we do for dataframe-matrix conversions, if I add the
following to {{FrameRDDConverterUtils.dataFrameToBinaryBlock}} it fixes the
issue on my cluster. However, while I can see the incorrect blocksizes while
debugging in a new local test, I'm unable to get it to actually fail locally.
Perhaps another rewrite is removing the reblock command locally?
{code}
//ensure valid blocksizes
if( mc.getRowsPerBlock()<=1 || mc.getColsPerBlock()<=1 ) {
mc.setBlockSize(ConfigurationManager.getBlocksize());
}
{code}
was (Author: [email protected]):
Indeed, the blocksizes were set to the default "1" when the metadata is
missing/empty. Like we do for dataframe-matrix conversions, if I add the
following to {{FrameRDDConverterUtils.dataFrameToBinaryBlock}} it fixes the
issue on my cluster. However, while I can see the incorrect blocksizes while
debugging in a new local test, I'm unable to get it to actually fail locally.
Perhaps another rewrite is removing the reblock command locally?
{code}
//ensure valid blocksizes
if( mc.getRowsPerBlock()<=1 || mc.getColsPerBlock()<=1 ) {
mc.setBlockSize(ConfigurationManager.getBlocksize());
}
{code}
> MLContext dataframe-frame conversion with index column & vector column
> ----------------------------------------------------------------------
>
> Key: SYSTEMML-995
> URL: https://issues.apache.org/jira/browse/SYSTEMML-995
> Project: SystemML
> Issue Type: Bug
> Components: APIs
> Affects Versions: SystemML 0.11
> Reporter: Matthias Boehm
> Priority: Blocker
>
> MLContext currently always assumes data frame to frame conversion without
> existing index column. Since the user cannot communicate the existence of
> this column, the data conversion leads to incorrect results as an additional
> column is included in the output frame. We need make the MLContext handling
> of frames consistent with the handling of matrices.
> Additionally, the conversion code in
> {{MLContextConversionUtil.dataFrameToFrameObject()}} does not yet take into
> account frames with vectors, although the recent addition adds this support
> in the underlying {{FrameRDDConverterUtils.java}} class. Therefore, the
> number of columns set when {{mc == null}} is incorrect.
> Thanks [[email protected]] for catching this issue. cc [~acs_s] [~deron]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
