----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20093/#review39764 -----------------------------------------------------------
tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java <https://reviews.apache.org/r/20093/#comment72373> Can you remove 'queryId.equals(QueryIdFactory.NULL_QUERY_ID)' ? it looks like duplicate checking - Jinho Kim On April 7, 2014, 6:47 p.m., Hyunsik Choi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20093/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 6:47 p.m.) > > > Review request for Tajo. > > > Bugs: TAJO-356 > https://issues.apache.org/jira/browse/TAJO-356 > > > Repository: tajo > > > Description > ------- > > Currently, TajoClient cannot deal with simple queries (e.g., select * from > table limit 1 or select 1) which are executed in TajoMaster without > distributed execution. The final results are always stored in HDFS, and > TajoClient gets the result via scanner with TableDesc obtained from > GetQueryResultResponse. > > For simple queries directly executed at TajoMaster, TajoClient needs to > directly get some binary serialized rows results from GetQueryStatusResponse > or GetQueryResultResponse instead of reading materialized tables. > > This feature would be also useful for low latency queries, EXPLAIN clauses > and expr-only statements without FROM clause. > > > Diffs > ----- > > CHANGES.txt f53f2a86fb1cfdc61b19d00ee220eef48a70cbfc > tajo-algebra/src/main/java/org/apache/tajo/algebra/Explain.java > PRE-CREATION > tajo-algebra/src/main/java/org/apache/tajo/algebra/OpType.java > a4fb617f81e6e03043c02f6792e72cea6c02e7ce > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java > f9f92f0876ab27e1c0c2694ec55e693d3bec3188 > > tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestCatalogUtil.java > f2d9f89a383d4e8cb3be7c008f67d5e538995562 > tajo-client/src/main/java/org/apache/tajo/cli/SimpleParser.java > 2146df74a1cbc0bf530eb0b0023e9f0cb52fd01f > tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java > 426c1155cc316f4ff59076c829597eda0ed182a9 > tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java > dc51b633d79ed8bdf457ae2ac125575827c14212 > tajo-client/src/main/java/org/apache/tajo/jdbc/TajoMemoryResultSet.java > PRE-CREATION > tajo-client/src/main/java/org/apache/tajo/jdbc/TajoResultSet.java > a64cea7d1d92e88e641008a6f701d69c4f28d369 > tajo-client/src/main/proto/ClientProtos.proto > 6e69a669dbb486aa48719b94d110f34cde75a5e5 > tajo-client/src/main/proto/TajoMasterClientProtocol.proto > 3bfd9dfbd69d72a4b032721211345fb1b360012a > > tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLLexer.g4 > 3b8f9cfd04694224cce832ae3eebb1e65323df37 > > tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 > 825969a397619e0ac76cde0294bfc437be870c5f > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java > 35ad4c2762d649dc93b5c48894ebf0151b4584ee > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/AlgebraVisitor.java > 0ea2c77093af7c1d9d390b12fece29d91a866bed > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java > 6f217a71b7cdaf93ce4a4a490dd5710183a258a0 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlan.java > c6d10d84c4381bc70c0737741ab8a82362b8c420 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java > 317c05b83f133aed27cb6b40e4fa5090193edbbf > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java > ccd984746911978c34eef27c017de457dd73b6b9 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/utils/TupleUtil.java > 9809aee3a43192a26e67249c981f95774534b68b > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalEngine.java > 0d5453c151aecc558bad6fbf7315cecd0d8a50c4 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMasterClientService.java > eed1007fab38e8c8d62158eafb461d02dba805cc > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java > df8b31b8c3d0354bb1a885d3f4384dabc9bbbfc5 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java > 24eea831c72ee3b358c03caa9afa54c5e1d1b5b2 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/RangeRetrieverHandler.java > 0e8ae72104be9b456dcd9099eadd307c982bb8d3 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/QueryTestCaseBase.java > e3ca39b16997667cea6f8068d7f65452b3a141ac > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/cli/TestSimpleParser.java > e52465266ff4015d6a35921bdcb8beade0d11de8 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestTajoClient.java > a2e318192cc00e9fc39be50e1e6cdd3bb5fa6211 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java > cf17d896e583d18d8282b5e751d3cba13cb7d400 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java > a75631a123e9080ed742226460e25cb5ceac8794 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/util/TestTupleUtil.java > 86fa798d25689780d0daa5675afb0428fe1b52c1 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/worker/TestRangeRetrieverHandler.java > 4e770ce0ec77c78c66dddd685d0a9787534cda26 > > tajo-core/tajo-core-backend/src/test/resources/queries/TestSelectQuery/testExplainSelect.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestSelectQuery/testNonFromSelect1.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestSelectQuery/testSimpleQuery.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestSelectQuery/testSimpleQueryWithLimit.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/results/TestSelectQuery/testExplainSelect.result > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/results/TestSelectQuery/testNonFromSelect1.result > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/results/TestSelectQuery/testSimpleQuery.result > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/results/TestSelectQuery/testSimpleQueryWithLimit.result > PRE-CREATION > > tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/pullserver/PullServerAuxService.java > afdae2395c34946debe4e1ea050893ee889845bc > > tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java > c416b6657d4a8e4d28737d678accc36f23e649e6 > tajo-storage/src/main/java/org/apache/tajo/storage/RowStoreUtil.java > 66d016b33b8732b491e37e85fe644f4e24f78337 > tajo-storage/src/main/java/org/apache/tajo/storage/index/bst/BSTIndex.java > b14958461120e90d545680e198b7ed0b9c08d835 > > Diff: https://reviews.apache.org/r/20093/diff/ > > > Testing > ------- > > > Thanks, > > Hyunsik Choi > >
