----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20093/#review39781 -----------------------------------------------------------
The latest patch reflects Jinho's comments and additionally cleans up some routines in TajoCli and TajoClient. - Hyunsik Choi On April 8, 2014, 8:55 p.m., Hyunsik Choi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20093/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 8:55 p.m.) > > > Review request for Tajo. > > > Bugs: TAJO-356 > https://issues.apache.org/jira/browse/TAJO-356 > > > Repository: tajo > > > Description > ------- > > Currently, TajoClient cannot deal with simple queries (e.g., select * from > table limit 1 or select 1) which are executed in TajoMaster without > distributed execution. The final results are always stored in HDFS, and > TajoClient gets the result via scanner with TableDesc obtained from > GetQueryResultResponse. > > For simple queries directly executed at TajoMaster, TajoClient needs to > directly get some binary serialized rows results from GetQueryStatusResponse > or GetQueryResultResponse instead of reading materialized tables. > > This feature would be also useful for low latency queries, EXPLAIN clauses > and expr-only statements without FROM clause. > > > Diffs > ----- > > CHANGES.txt 9412ae4 > tajo-algebra/src/main/java/org/apache/tajo/algebra/Explain.java > PRE-CREATION > tajo-algebra/src/main/java/org/apache/tajo/algebra/OpType.java a4fb617 > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java > f9f92f0 > > tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestCatalogUtil.java > f2d9f89 > tajo-client/src/main/java/org/apache/tajo/cli/SimpleParser.java 2146df7 > tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java 2a49d0b > tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java dc51b63 > tajo-client/src/main/java/org/apache/tajo/jdbc/TajoMemoryResultSet.java > PRE-CREATION > tajo-client/src/main/java/org/apache/tajo/jdbc/TajoResultSet.java a64cea7 > tajo-client/src/main/proto/ClientProtos.proto 6e69a66 > tajo-client/src/main/proto/TajoMasterClientProtocol.proto 3bfd9df > > tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLLexer.g4 > 3b8f9cf > > tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 > f25b41f > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java > 3edf768 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/AlgebraVisitor.java > 0ea2c77 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java > 6f217a7 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlan.java > a24f25f > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java > 317c05b > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java > ccd9847 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/utils/TupleUtil.java > 9809aee > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalEngine.java > a56284b > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMasterClientService.java > eed1007 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java > df8b31b > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java > 24eea83 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/RangeRetrieverHandler.java > 0e8ae72 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/QueryTestCaseBase.java > e3ca39b > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/cli/TestSimpleParser.java > e524652 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestTajoClient.java > a2e3181 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java > cf17d89 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java > a75631a > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/util/TestTupleUtil.java > 86fa798 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/worker/TestRangeRetrieverHandler.java > 4e770ce > > tajo-core/tajo-core-backend/src/test/resources/queries/TestSelectQuery/testExplainSelect.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestSelectQuery/testNonFromSelect1.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestSelectQuery/testSimpleQuery.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestSelectQuery/testSimpleQueryWithLimit.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/results/TestSelectQuery/testExplainSelect.result > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/results/TestSelectQuery/testNonFromSelect1.result > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/results/TestSelectQuery/testSimpleQuery.result > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/results/TestSelectQuery/testSimpleQueryWithLimit.result > PRE-CREATION > > tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/pullserver/PullServerAuxService.java > afdae23 > > tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java > c416b66 > tajo-storage/src/main/java/org/apache/tajo/storage/RowStoreUtil.java > 66d016b > tajo-storage/src/main/java/org/apache/tajo/storage/index/bst/BSTIndex.java > b149584 > > Diff: https://reviews.apache.org/r/20093/diff/ > > > Testing > ------- > > > Thanks, > > Hyunsik Choi > >
