----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21325/#review43584 -----------------------------------------------------------
Ship it! +1 The patch looks good to me. - Hyunsik Choi On May 20, 2014, 3:11 p.m., Jung JaeHwa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21325/ > ----------------------------------------------------------- > > (Updated May 20, 2014, 3:11 p.m.) > > > Review request for Tajo. > > > Bugs: TAJO-819 > https://issues.apache.org/jira/browse/TAJO-819 > > > Repository: tajo > > > Description > ------- > > There are two types of killing queries. First is that QueryMaster cancel > QueryUnitAttempt before QueryUnitAttempt be passed to TajoWorker. Second is > that TajoWorker cancel running QueryUnitAttempt. > > If QueryMaster cancel QueryUnitAttempts, it will be stopped. But > unfortunately, at nearly the same time, a few QueryUnitAttempts can be passed > to TajoWorker. And these never will be stopped because it can't find valid > state for state machines. > > > Diffs > ----- > > tajo-core/src/main/java/org/apache/tajo/master/querymaster/Query.java > 2848095 > tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryUnit.java > 27625b4 > > tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java > c3aae67 > tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java > 08517ef > tajo-core/src/main/java/org/apache/tajo/master/rm/TajoRMContext.java > a995058 > > tajo-core/src/main/java/org/apache/tajo/master/rm/TajoWorkerResourceManager.java > 15ac6b6 > tajo-core/src/main/java/org/apache/tajo/master/rm/Worker.java 0d6b5ee > > tajo-core/src/test/java/org/apache/tajo/master/rm/TestTajoResourceManager.java > 34deb29 > > Diff: https://reviews.apache.org/r/21325/diff/ > > > Testing > ------- > > mvn clean install -Phcatalog-0.12.0 > -Dtajo.catalog.store.class=org.apache.tajo.catalog.store.HCatalogStore > > > Thanks, > > Jung JaeHwa > >
