-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21325/
-----------------------------------------------------------
(Updated May 21, 2014, 6:10 a.m.)
Review request for Tajo.
Changes
-------
I updated the patch as follows:
- Update TajoClient::killQuery returning type.
- Add kill button at query.jsp
- Add kill condition at FetchRunner
Bugs: TAJO-819
https://issues.apache.org/jira/browse/TAJO-819
Repository: tajo
Description
-------
There are two types of killing queries. First is that QueryMaster cancel
QueryUnitAttempt before QueryUnitAttempt be passed to TajoWorker. Second is
that TajoWorker cancel running QueryUnitAttempt.
If QueryMaster cancel QueryUnitAttempts, it will be stopped. But
unfortunately, at nearly the same time, a few QueryUnitAttempts can be passed
to TajoWorker. And these never will be stopped because it can't find valid
state for state machines.
Diffs (updated)
-----
tajo-client/src/main/java/org/apache/tajo/client/TajoAdmin.java 25b91a4
tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java 7d84592
tajo-core/src/main/java/org/apache/tajo/master/querymaster/Query.java 2848095
tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryUnit.java
27625b4
tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java
c3aae67
tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
08517ef
tajo-core/src/main/java/org/apache/tajo/master/rm/TajoRMContext.java a995058
tajo-core/src/main/java/org/apache/tajo/master/rm/TajoWorkerResourceManager.java
15ac6b6
tajo-core/src/main/java/org/apache/tajo/master/rm/Worker.java 0d6b5ee
tajo-core/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java
faeadaf
tajo-core/src/main/java/org/apache/tajo/worker/Task.java 4010faf
tajo-core/src/main/resources/webapps/admin/query.jsp 4e8d7b0
tajo-core/src/test/java/org/apache/tajo/master/rm/TestTajoResourceManager.java
34deb29
Diff: https://reviews.apache.org/r/21325/diff/
Testing
-------
mvn clean install -Phcatalog-0.12.0
-Dtajo.catalog.store.class=org.apache.tajo.catalog.store.HCatalogStore
Thanks,
Jung JaeHwa
