Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/13#discussion_r13048813
--- Diff:
tajo-algebra/src/main/java/org/apache/tajo/algebra/WindowSpecExpr.java ---
@@ -19,17 +19,14 @@
package org.apache.tajo.algebra;
import com.google.common.base.Objects;
+import com.google.gson.annotations.Expose;
import org.apache.tajo.util.TUtil;
-public class WindowSpecExpr extends Expr {
- private String windowName;
- private Expr [] partitionKeys; // OVER (PARTITION BY ?,...,?)
- private Sort.SortSpec [] sortSpecs; // OVER (... ORDER BY ?,...,?)
- private WindowFrame windowFrame;
-
- public WindowSpecExpr() {
- super(OpType.WindowSpec);
- }
+public class WindowSpecExpr implements Cloneable {
--- End diff --
The name can make users confused. Would you change the name not including
'Expr'?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
