Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/13#issuecomment-45691619
  
    Thank you for the review.
    
    I pushed the latest updated code for window function. The last revision 
adds lots of verification codes and allows OVER clause to support aggregation 
expressions. In other words, users can directly use aggregation functions 
within OVER clause.
    
    Example:
    ```
    select l_orderkey, count(*) as cnt, row_number() over (order by count(*) 
desc) row_num from lineitem group by l_orderkey order by l_orderkey
    ```
    
    or 
    
    ```
    select l_orderkey, row_number() over (partition by l_orderkey order by 
count(*) desc) row_num from lineitem group by l_orderkey;
    ```
    
    I've added a number of unit tests for various cases which can be used in 
OVER clause. I verified 'mvn clean install'.
    
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to