Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/13#discussion_r13899755
--- Diff:
tajo-core/src/main/java/org/apache/tajo/engine/eval/WindowFunctionEval.java ---
@@ -0,0 +1,99 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.tajo.engine.eval;
+
+import com.google.gson.annotations.Expose;
+import org.apache.tajo.catalog.FunctionDesc;
+import org.apache.tajo.catalog.Schema;
+import org.apache.tajo.catalog.SortSpec;
+import org.apache.tajo.common.TajoDataTypes.DataType;
+import org.apache.tajo.datum.Datum;
+import org.apache.tajo.engine.function.AggFunction;
+import org.apache.tajo.engine.function.FunctionContext;
+import org.apache.tajo.engine.planner.logical.WindowSpec;
+import org.apache.tajo.storage.Tuple;
+import org.apache.tajo.storage.VTuple;
+
+public class WindowFunctionEval extends AggregationFunctionCallEval
implements Cloneable {
+ @Expose private SortSpec [] sortSpecs;
+ @Expose WindowSpec.WindowFrame windowFrame;
+ private Tuple params;
+
+ public WindowFunctionEval(FunctionDesc desc, AggFunction instance,
EvalNode[] givenArgs,
+ WindowSpec.WindowFrame windowFrame) {
+ super(EvalType.WINDOW_FUNCTION, desc, instance, givenArgs);
+ this.windowFrame = windowFrame;
+ }
+
+ public boolean hasSortSpecs() {
+ return sortSpecs != null;
+ }
+
+ public void setSortSpecs(SortSpec [] sortSpecs) {
+ this.sortSpecs = sortSpecs;
+ }
+
+ public SortSpec [] getSortSpecs() {
+ return sortSpecs;
+ }
+
+ public WindowSpec.WindowFrame getWindowFrame() {
+ return windowFrame;
+ }
+
+ @Override
+ public Datum eval(Schema schema, Tuple tuple) {
+ throw new UnsupportedOperationException("Cannot execute eval() of
aggregation function");
+ }
+
+ public void merge(FunctionContext context, Schema schema, Tuple tuple) {
+ if (params == null) {
+ this.params = new VTuple(argEvals.length);
+ }
+
+ if (argEvals != null) {
+ for (int i = 0; i < argEvals.length; i++) {
+ params.put(i, argEvals[i].eval(schema, tuple));
+ }
+ }
+
+ instance.eval(context, params);
+ }
+
+ public Datum terminate(FunctionContext context) {
+ return instance.terminate(context);
+ }
+
+ @Override
+ public DataType getValueType() {
+ return funcDesc.getReturnType();
+ }
+
+ @Override
+ public Object clone() throws CloneNotSupportedException {
+ WindowFunctionEval windowFunctionEval = (WindowFunctionEval)
super.clone();
--- End diff --
windowFrame should be cloned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---