Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/13#discussion_r13899554
--- Diff:
tajo-algebra/src/main/java/org/apache/tajo/algebra/WindowSpec.java ---
@@ -109,10 +136,10 @@ boolean equalsTo(Expr expr) {
FOLLOWING
}
- public static class WindowFrame {
- WindowFrameUnit unit;
- private WindowStartBound startBound;
- private WindowEndBound endBound;
+ public static class WindowFrame implements Cloneable {
+ @Expose WindowFrameUnit unit;
--- End diff --
It would be better to specify an explicit access modifier.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
