[
https://issues.apache.org/jira/browse/TAJO-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053349#comment-14053349
]
ASF GitHub Bot commented on TAJO-911:
-------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/59#issuecomment-48141635
The patch looks good to me. It's just a question. Did you test it on a
local or real cluster? This is because I'm concerned with the difficulty of
integrated unit tests of catalog drivers like MySQL or MariaDB.
> Refactoring Mysql/Maria Catalog Store
> -------------------------------------
>
> Key: TAJO-911
> URL: https://issues.apache.org/jira/browse/TAJO-911
> Project: Tajo
> Issue Type: Improvement
> Reporter: DaeMyung Kang
> Assignee: DaeMyung Kang
> Priority: Minor
>
> MysqlStore and MariaDBStore are almost same.
> so, it is better to make one parent class.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
