[
https://issues.apache.org/jira/browse/TAJO-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054474#comment-14054474
]
ASF GitHub Bot commented on TAJO-911:
-------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/59#issuecomment-48268446
+1
the patch looks good to me. Thank you for sharing your test result. I've
also tested TestCatalog agsinst MySQL. I'll commit it shortly.
This documentation may be useful to you.
https://cwiki.apache.org/confluence/display/TAJO/Unit+Tests
Aside from this issue, I'm concerning with integration test of
mysql/mariadb catalog driver. For example, we can do 'mvn clean install' with
an external mysql as a catalog store. I'll discuss it more in another Jira
issue when we needed.
Aside from this issue, I'm concerning with
> Refactoring Mysql/Maria Catalog Store
> -------------------------------------
>
> Key: TAJO-911
> URL: https://issues.apache.org/jira/browse/TAJO-911
> Project: Tajo
> Issue Type: Improvement
> Reporter: DaeMyung Kang
> Assignee: DaeMyung Kang
> Priority: Minor
>
> MysqlStore and MariaDBStore are almost same.
> so, it is better to make one parent class.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
