[ 
https://issues.apache.org/jira/browse/TAJO-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060481#comment-14060481
 ] 

ASF GitHub Bot commented on TAJO-904:
-------------------------------------

Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/70#discussion_r14870602
  
    --- Diff: 
tajo-core/src/test/java/org/apache/tajo/engine/query/TestSortQuery.java ---
    @@ -169,4 +177,46 @@ public final void testTopkWithJson() throws Exception {
         assertResultSet(res);
         cleanupQuery(res);
       }
    +
    +  @Test
    +  public final void testSortNullColumn() throws Exception {
    +    try {
    +      executeString("DROP TABLE table1 PURGE;").close();
    --- End diff --
    
    It should be ```DROP TABLE IF EXISTS table 1 PURGE```. Otherwise, it will 
cause 'no such table error' when a developer executes this test separately.


> ORDER BY with a null column miss some data.
> -------------------------------------------
>
>                 Key: TAJO-904
>                 URL: https://issues.apache.org/jira/browse/TAJO-904
>             Project: Tajo
>          Issue Type: Bug
>            Reporter: Hyoungjun Kim
>            Assignee: Hyoungjun Kim
>            Priority: Trivial
>
> ORDER BY with a null column miss some data. I found RowStoreEncoder has a bug 
> dealing with NULL values. 
> "continue" statement should be add.
> {code}
>       Column col;
>       for (int i = 0; i < schema.size(); i++) {
>         if (tuple.isNull(i)) {
>           nullFlags.set(i);
>           continue;
>         }
>         col = schema.getColumn(i);
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to