[
https://issues.apache.org/jira/browse/TAJO-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061683#comment-14061683
]
ASF GitHub Bot commented on TAJO-904:
-------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/70#issuecomment-48992032
It works well for null first case. But, in null last case, the query
results in empty rows.
In my view, null last supports is not trivial and requires a bunch of
codes. In contrast, the current patch looks reasonable for only null first.
If there is no objection, I'll change the issue name to 'ORDER BY NULL
FIRST support', and I'll create another issue for null last.
> ORDER BY with a null column miss some data.
> -------------------------------------------
>
> Key: TAJO-904
> URL: https://issues.apache.org/jira/browse/TAJO-904
> Project: Tajo
> Issue Type: Bug
> Reporter: Hyoungjun Kim
> Assignee: Hyoungjun Kim
> Priority: Trivial
>
> ORDER BY with a null column miss some data. I found RowStoreEncoder has a bug
> dealing with NULL values.
> "continue" statement should be add.
> {code}
> Column col;
> for (int i = 0; i < schema.size(); i++) {
> if (tuple.isNull(i)) {
> nullFlags.set(i);
> continue;
> }
> col = schema.getColumn(i);
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
