[
https://issues.apache.org/jira/browse/TAJO-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067856#comment-14067856
]
ASF GitHub Bot commented on TAJO-960:
-------------------------------------
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/83
TAJO-960: TajoCli's problem does not show the current status.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-960
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/83.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #83
----
commit b01e4635929eb6300150bc3b4cd67d1f544a1adb
Author: Hyunsik Choi <[email protected]>
Date: 2014-07-20T08:46:59Z
TAJO-960: TajoCli's problem does not show the current status.
----
> TajoCli's problem does not show the current status
> --------------------------------------------------
>
> Key: TAJO-960
> URL: https://issues.apache.org/jira/browse/TAJO-960
> Project: Tajo
> Issue Type: Bug
> Reporter: Hyunsik Choi
> Priority: Trivial
> Fix For: 0.9.0
>
>
> TajoCli is designed to show the status of completeness of SQL statements.
> For example, it should work as follows:
> {noformat}
> tpch> CREATE TABLE T1 (
> > l_orderkey INT,
> > l_partkey INT)
> >
> Created T1
> tpch> SELECT
> > t1,
> > ..
> {noformat}
> But, the current TajoCli does not handle this status. So, it works as follows:
> {noformat}
> tpch> CREATE TABLE T1 (
> tpch> t1 int,
> tpch> t2 int);
> Created T1
> tpch>
> {noformat}
> Users cannot know if current status continues to take statements or is a
> ready status to start new statement.
> The solution is to place {{executeParsedResults(parsedResults);}} and
> {{currentPrompt = updatePrompt(parser.getState());}} to outside of {{if
> (parsedResults.size() > 0)}} statement.
> {noformat}
> if (parsedResults.size() > 0) {
> for (ParsedResult parsed : parsedResults) {
> history.addStatement(parsed.getHistoryStatement() +
> (parsed.getType() == STATEMENT ? ";" : ""));
> }
> executeParsedResults(parsedResults);
> currentPrompt = updatePrompt(parser.getState());
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
