[
https://issues.apache.org/jira/browse/TAJO-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067908#comment-14067908
]
ASF GitHub Bot commented on TAJO-960:
-------------------------------------
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/83#issuecomment-49545084
+1
Good idea! The patch ran as expected on my testing cluster.
Push it. :)
> TajoCli's problem does not show the current status
> --------------------------------------------------
>
> Key: TAJO-960
> URL: https://issues.apache.org/jira/browse/TAJO-960
> Project: Tajo
> Issue Type: Bug
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Priority: Trivial
> Fix For: 0.9.0
>
>
> TajoCli is designed to show the status of completeness of SQL statements.
> For example, it should work as follows:
> {noformat}
> tpch> CREATE TABLE T1 (
> > l_orderkey INT,
> > l_partkey INT)
> >
> Created T1
> tpch> SELECT
> > t1,
> > ..
> {noformat}
> But, the current TajoCli does not handle this status. So, it works as follows:
> {noformat}
> tpch> CREATE TABLE T1 (
> tpch> t1 int,
> tpch> t2 int);
> Created T1
> tpch>
> {noformat}
> Users cannot know if current status continues to take statements or is a
> ready status to start new statement.
> The solution is to place {{executeParsedResults(parsedResults);}} and
> {{currentPrompt = updatePrompt(parser.getState());}} to outside of {{if
> (parsedResults.size() > 0)}} statement.
> {noformat}
> if (parsedResults.size() > 0) {
> for (ParsedResult parsed : parsedResults) {
> history.addStatement(parsed.getHistoryStatement() +
> (parsed.getType() == STATEMENT ? ";" : ""));
> }
> executeParsedResults(parsedResults);
> currentPrompt = updatePrompt(parser.getState());
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
