----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25242/#review54298 -----------------------------------------------------------
I'm reviewing the patch. I have one suggestion. You still use tab, but in our coding standards we use 2 space instead of tab. In this time, I'll reindent the some parts. Please keep coding standard in next time. Thank you for your contribution! - Hyunsik Choi On Sept. 23, 2014, 11:01 a.m., Hai Thanh Mai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25242/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 11:01 a.m.) > > > Review request for Tajo and Hyunsik Choi. > > > Repository: tajo > > > Description > ------- > > TAJO-983: Worker should directly read Intermediate data stored in localhost > rather than fetching > > Currently, worker always fetches all intermediate via Fetcher and than store > them in local file system even though some intermediate data already are > stored in local file system. It is inefficient and causes unnecessary I/O and > extra storage occupation. We should improve it. > > https://issues.apache.org/jira/browse/TAJO-983 > > > Diffs > ----- > > > tajo-core/src/main/java/org/apache/tajo/engine/planner/UniformRangePartition.java > db12285 > > tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java > 700e34d > tajo-core/src/main/java/org/apache/tajo/worker/Fetcher.java 4867fe4 > tajo-core/src/main/java/org/apache/tajo/worker/Task.java 66e0f87 > tajo-core/src/test/java/org/apache/tajo/worker/TestFetcher.java b15d523 > tajo-storage/src/main/java/org/apache/tajo/storage/RawFile.java 1f57675 > > tajo-yarn-pullserver/src/main/java/org/apache/tajo/pullserver/PullServerAuxService.java > 5f9f9e8 > > tajo-yarn-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java > 3fa67ae > > tajo-yarn-pullserver/src/main/java/org/apache/tajo/pullserver/retriever/FileChunk.java > a8b424e > > Diff: https://reviews.apache.org/r/25242/diff/ > > > Testing > ------- > > > Thanks, > > Hai Thanh Mai > >
