Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/206#issuecomment-60473494
I greatly appreciate your contribution. The patch looks really great. I
love your design.
Actually, I didn't mention how we validate each config key. Of course, it
is out of scope of this issue. Now, I just share it with you.
In my plan, Tajo will validate configs in two ways.
The first way is that TajoMaster validates each config when it starts up.
If TajoMaster finds invalid config which probably will cause query runtime
errors, TajoMaster will shutdown immediately and prints out detailed error
messages. If so, we can earlier prohibit some kind of query runtime errors.
The second one is that TajoMaster checks each session setting action by
client. If a client sets an invalid session variable, it will show some errors
and prohibit putting the invalid variable into session variables.
If you fix the validator for ```tajo.username``` and rebase it, I'll finish
the review.
Best regards,
Hyunsik
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
