GitHub user ykrips opened a pull request:

    https://github.com/apache/tajo/pull/218

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

    I cannot expect that generic signature of IsCollectionContaining is broken. 
After the quick review on source code fo IsCollectionContaining, I found the 
broken point on this class, and add a workaround function on the test case.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ykrips/tajo TAJO-1114

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/218.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #218
    
----
commit 412e2e6b8fcd208ded929df100d2ee80ee7a0281
Author: Jihun Kang <[email protected]>
Date:   2014-10-17T09:53:13Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit 44b991b43318da6d91758c3ef43232bd71414352
Author: Jihun Kang <[email protected]>
Date:   2014-10-20T06:47:34Z

    Merge remote-tracking branch 'upstream/master' into TAJO-1114

commit 76720f853dd22b245207d2de8e49fcc9554562f5
Author: Jihun Kang <[email protected]>
Date:   2014-10-20T07:13:01Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit f99e7edcfa51c2955da7a54af4a2edf7b11c6068
Author: Jihun Kang <[email protected]>
Date:   2014-10-20T07:13:53Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit 0ad448d1e51a35778b527a952dbd2c36345579e5
Author: Jihun Kang <[email protected]>
Date:   2014-10-20T07:15:00Z

    Merge remote-tracking branch 'upstream/master' into TAJO-1114

commit ce0fb6d44e5782c28618b735d95b10c57d3f4692
Author: Jihun Kang <[email protected]>
Date:   2014-10-20T12:47:27Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit 3f3a23a138cc523316cd2b28f1251921a55d404e
Author: Jihun Kang <[email protected]>
Date:   2014-10-20T13:02:30Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit b953102a48bb75136172a584d95191273a386903
Author: Jihun Kang <[email protected]>
Date:   2014-10-17T09:53:13Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit c510067ce5665a431230e5e56efa574f014bb85d
Author: Jihun Kang <[email protected]>
Date:   2014-10-20T07:13:01Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit 9d666ef75662c36e825b6bcdc1cd22e30d6c59af
Author: Jihun Kang <[email protected]>
Date:   2014-10-20T07:13:53Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit 1b5088bcf515f2e6706be1d1dbec515a9885b8e4
Author: Jihun Kang <[email protected]>
Date:   2014-10-20T12:47:27Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit 7c92470a100732434e3aa453978c5b498eecca6e
Author: Jihun Kang <[email protected]>
Date:   2014-10-20T13:02:30Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit b49df082a32d2bb5a987c7444b0b4b0e94fa8836
Author: Jihun Kang <[email protected]>
Date:   2014-10-27T08:52:58Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit cc5d128a3a5c2701ed119b7d6de9b8aa81799c08
Author: Jihun Kang <[email protected]>
Date:   2014-10-27T09:00:32Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit 5b5fc3995cba4fced25563b35e1966db5a8812d9
Author: Jihun Kang <[email protected]>
Date:   2014-10-27T09:10:41Z

    Removed validate functions from OverridableConf

commit d0ee8cd3c52cec0588af53ad8554e40ba437f711
Author: Jihun Kang <[email protected]>
Date:   2014-10-27T09:14:09Z

    Removed unused conf

commit 5a9b44b1f6dc6d960721b9a5154cbd33df389882
Author: Jihun Kang <[email protected]>
Date:   2014-10-27T09:31:27Z

    Merge branch 'TAJO-1114' of https://github.com/ykrips/tajo into TAJO-1114

commit 9b5c350e870a236c37dfa69af2c33469673c977c
Author: Jihun Kang <[email protected]>
Date:   2014-10-27T09:32:44Z

    Removed useless testcase

commit 76ae262cee268bffacf77fd63c9f17a82d231583
Author: Jihun Kang <[email protected]>
Date:   2014-10-27T11:59:33Z

    Re-create validateProperty function

commit 57cdb09785815295784f5aa846a9ed1b2e3d82e0
Author: Jihun Kang <[email protected]>
Date:   2014-10-27T12:02:42Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit 60bb94b3559ad7c2c339a9978b87e85c59655703
Author: Jihun Kang <[email protected]>
Date:   2014-10-28T02:45:26Z

    Add workarounds for a bug on hadItem function of hamcrest-core

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to