Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/303#discussion_r21949532
  
    --- Diff: tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java ---
    @@ -272,6 +272,10 @@ public static int setDateOrder(int dateOrder) {
         // Geo IP
         GEOIP_DATA("tajo.function.geoip-database-location", ""),
     
    +    // Storage IO BUFFER
    +    STORAGE_IO_WRITE_BUFFER_SIZE("tajo.io.write.buffer.size", 128 * 1024),
    +    STORAGE_IO_READ_BUFFER_SIZE("tajo.io.read.buffer.size", 128 * 1024),
    --- End diff --
    
    They seem buffer sizes for HDFS.
    I think that we will support various types of storages.
    In addition, it would be more intuititive if it represents the size unit 
such as KB.
    So, how about change the property name such as 
tajo.hdfs.write.buffer.size.KB?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to