Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/303#discussion_r21950158
--- Diff: tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java ---
@@ -272,6 +272,10 @@ public static int setDateOrder(int dateOrder) {
// Geo IP
GEOIP_DATA("tajo.function.geoip-database-location", ""),
+ // Storage IO BUFFER
+ STORAGE_IO_WRITE_BUFFER_SIZE("tajo.io.write.buffer.size", 128 * 1024),
+ STORAGE_IO_READ_BUFFER_SIZE("tajo.io.read.buffer.size", 128 * 1024),
--- End diff --
BTW, I also have the same concern about the config key name. The properties
may vary in file formats.
So, I propose using ```storage-default.xml``` and
```tajo.storage.[storetype].io.read-buffer.bytes``` which can be specified
according to file formats.
Our config naming convention includes some unit like ```bytes``` or
```mb``` because it reduces misuse of values. So, I'd like to suggest
```io.read-buffer.bytes``` or ```io.write-buffer.bytes``` for table properties.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
