Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/322#issuecomment-68246166
In this patch, I mainly did as follows:
* Change TaskRequestProto to use protobuf serialized plan instead JSON
serialized plan
* Implement LogicalNodeTreeSerializer and LogicalNodeTreeDeserializer
In order to verify the de/serialization of logical plan, I injected some
test codes to check equality between the original plan and a restored plan from
serialized protobuf plan. For it, I've improved GlobalPlanner to have some
rewrite engine, and I changed TajoTestingCluster to inject additional rewrite
rules to check the equality. As a result, I added two rewrite rules:
* GlobalPlanEqualityTester
* LogicalPlanEqualityTester
While I'm working on it, I corrected some wrong or bad names as follow.
* Rename BasicLogicalPlanVisitor::visitDistinct to visitDistinctGroupby
* Rename RelationNode::getLogicalSchema to getTableSchema
* Rename DistingtGroupbyNode::getGroupByNodes to getSubPlans
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
